CGI-Wiki-dev December 2003

cgi-wiki-dev@earth.li

5 participants
7 discussions

(no subject)
by Jody Belka 20 Dec '03

20 Dec '03

Thought this up friday afternoon, had the domain registered and active by the evening, and the site running by morning today. Let me know what you think. http://test-sites.org Jody

1 0

Announcing CGI::Wiki::Plugin::Diff 0.04
by Ivor Williams 19 Dec '03

19 Dec '03

I have just uploaded this to CPAN. It fixes an annoying bug with <BR /> tags. Also included is the ability to choose which metadata fields appear in the diff. Note: this requires VCS::Lite 0.05.

1 0

CGI-Wiki-Kwiki-0.45 with added diffs, please test
by Ivor Williams 12 Dec '03

12 Dec '03

I have an update to CGI::Wiki::Kwiki to integrate it with my diffing module CGI::Wiki::Plugin::Diff. I attach a tar kit with the full change, including a new template file and updates to CHANGES, MANIFEST, Build.PL etc. I do not have the facilities to run this up as a full wiki site :(. Please can some of you have a go at break^Wtesting it. Just in case mailmangler mangles the tarball, I am including the main body of the change, as a patch to Kwiki.pm: --- CGI-Wiki-Kwiki-0.44/lib/CGI/Wiki/Kwiki.pm Mon Nov 24 20:05:37 2003 +++ CGI-Wiki-Kwiki-0.45/lib/CGI/Wiki/Kwiki.pm Sun Dec 7 12:32:20 2003 @@ -152,9 +152,10 @@ use CGI::Wiki; use Search::InvertedIndex; use CGI::Wiki::Search::SII; +use CGI::Wiki::Plugin::Diff; use Template; -our $VERSION = '0.44'; +our $VERSION = '0.45'; my $default_options = { db_type => 'MySQL', @@ -177,6 +178,8 @@ search_map => "./search_map", }; +our $diff_plugin = CGI::Wiki::Plugin::Diff->new; + sub new { my $class = shift; my $self = bless {}, $class; @@ -246,6 +249,8 @@ search => $self->{search}, ) or die "Can't create CGI::Wiki object"; + $self->{wiki}->register_plugin( plugin => $diff_plugin ); + return $self; } @@ -313,8 +318,14 @@ } else { - if ($args{diffversion}) { - die "diff not implemented yet\n"; + if ($args{diffversion}) { + my %diff = $diff_plugin->differences( + node => $node, + left_version => $args{version}, + right_version => $args{diffversion} ); + + $self->process_template('differences.tt', $node, \%diff); + } else { $self->display_node($node, $args{version}); } ======End of patch========================

4 12

Jody's three patches
by Kate L Pugh 08 Dec '03

08 Dec '03

Thanks for the patches, Jody. As discussed on IRC, the table-prefix stuff does need a little more testing before it goes in. I'm also concerned about quadrupling the test run time... So to confirm, the plan is that you will send me the other two patches made against 0.50_02 and I'll do my best to get them in this weekend. Kake

2 1

::Database::node_exists
by Jody Belka 04 Dec '03

04 Dec '03

Whilst i was working on the previous patch i posted, i noticed that the node_exists routine doesn't do exactly as documented. The documentation states that it returns true if the node has ever been created, and false otherwise. Now, strictly speaking this is correct, but the truth value is actually the version number of the node. Also, it's retrieving the entire node, including metadata, to do this. Now (in some formatters), this method is called for every internal link on a node to determine how to show the link, so it is in the best interest to do the minimum necessary. Therefore, what i suggest (after having talked it over with Earle), is to seperate node_exists into two seperate methods, one called node_exists that only does this check, and nothing more, and another called node_version, that is actually documented as returning the version number. I have included two patches along these lines. One of them (CGI-Wiki-node_exists.diff) is against 0.50_01. The other is against my local dev-tree, which so far consists only of this patch and the earlier two. Included along with the new method is a new test file that makes sure it is working properly. Thankfully, unlike the table-prefix changes, this does not add a very significant amount of time to the test run ;) -- Jody Belka knew (at) pimb (dot) org Modules/Diffs @ perl.pimb.org/modules

1 0

C::W::Store::* diff
by Jody Belka 04 Dec '03

04 Dec '03

This is a diff against CGI::Wiki::Store::* that splits out the SQL portions of some more of the methods in ::Database, and renames the one existing sql-method that was there. The purpose of this patch is to make changing some of the sql in descendents possible without having to copy in the appropriate routine. I haven't changed all of the methods, as some of them don't seem to make much sense split out. This came about as support for some other code I was writing, which does some inheritence from various parts of CGI::Wiki and needed some changes to the SQL statements. I'll post more about this at a later date. *** Important Note ***: This diff is not made against current code, but against the previous diff I posted to the list, which was against 0.50_01. At the point i'm sending this mail, the previous one has not appeared yet, so I will also mention that both diffs can be found at http://perl.pimb.org/modules/ -- Jody Belka knew (at) pimb (dot) org

1 0

updated table-prefix diff against 0.50_01
by Jody Belka 04 Dec '03

04 Dec '03

Enclosed is the updated version of my table-prefix diff, which includes changes to the db setup scripts unlike the previous version. I promised this to Kake a while back now, but only just got round to doing it, sorry. -- Jody knew (at) pimb (dot) org

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

CGI-Wiki-dev December 2003