On Mon 23 Feb 2004, rootmj rootmj_konf@seznam.cz wrote:

CGI-Wiki-Store-Kwiki-0.01 : http://kwikimj.kn.vutbr.cz/downloads/CGI-Wiki/CGI-Wiki-Store-Kwiki-0.01.pm

This does look very interesting. I note that you are inheriting from CGI::Wiki::Store::Database - I had envisaged this being the base class for actual RDBMS backends. The base class for all store backends should really be called something like CGI::Wiki::Datastore, and then CGI::Wiki::Datastore::DBI and CGI::Wiki::Datastore::Kwiki would inherit from that. What do you think?

Kake

Kate L Pugh wrote:

This does look very interesting. I note that you are inheriting from CGI::Wiki::Store::Database - I had envisaged this being the base class for actual RDBMS backends. The base class for all store backends should really be called something like CGI::Wiki::Datastore, and then CGI::Wiki::Datastore::DBI and CGI::Wiki::Datastore::Kwiki would inherit from that. What do you think?

I agree. It can looks like?

CGI::Wiki::Datastore new _init _checksum _checksum_hashes verify_checksum _get_timestamp retrieve_node list_recent_changes

CGI::Wiki::Datastore::Kwiki use base qw(CGI::Wiki::Datastore); _init _retrieve_node_data _retrieve_node_content check_and_write_node write_node_post_locking _find_recent_changes_by_criteria

CGI-Wiki-Store-Kwiki-0.03 - Checksum added. http://kwikimj.kn.vutbr.cz/downloads/CGI-Wiki/CGI-Wiki-Store-Kwiki-0.03.pm

On Tue 24 Feb 2004, Justin Kao justin+earth@dicatek.com wrote:

Why is it C::W::Datastore instead of C::W::Store? (Not objecting, just not sure what is being implied by the name change.)

(a) I think it's a better description of what it is. A Datastore stores data (as opposed to say indexes). (b) It's a non-verbable noun. When you look at a method called ->store, what does that do? Does it store something or does it return an object capable of storing things?

I guess we're going to need to keep the old names of CGI::Wiki::Store::MySQL etc though, since people won't want to rewrite all of their code, so let's stick with CGI::Wiki::Store::*

I *will* rename CGI::Wiki::Store::Database to CGI::Wiki::Store::DBI, though, unless someone can come up with a reason why I shouldn't.

Kake