[E3-hacking] [PATCH v2 1/6] SoC Camera: add driver for OMAP1 camera interface

Ralph Corderoy ralph at inputplus.co.uk
Sun Sep 19 16:06:58 BST 2010


Hi Janusz,

> This is a V4L2 driver for TI OMAP1 SoC camera interface.
>
> +				"0x%0x\n", __func__, it_status);
> +				"0x%0x\n", __func__, it_status);
> +		dev_warn(dev, "%s: format %#x not found\n", __func__,
> +		dev_warn(icd->dev.parent, "Format %#x not found\n",

Two bytes could be saved with consistent use of %#x.  :-)  Does it make
sense to say `%0x' without giving a field width to pad to?  That's
another two bytes saved.  A veritable word!

Cheers,
Ralph.




More information about the e3-hacking mailing list