[E3-hacking] [RFC] [PATCH 3/6] SoC Camera: add driver for OV6650 sensor

[Ralph Corderoy]

Hi Janusz,

> Before Jonathan gets his opportunity to push it through, here you can
> find a copy for review:
> http://www.spinics.net/lists/linux-media/msg21063.html

> +   switch (vb->state) {
> ...
> +   default:
> +       dev_dbg(dev, "%s (unknown)\n", __func__);
> +       break;

Include vb->state's value in the debug?

> +    * if exactly 2 sgbufs of the next sglist has be used,
> +    * then we are in sync

"been used".

> +    dev_warn(pcdev->soc_host.v4l2_dev.dev, "%s: "
> +        "unhandled camera interrupt, status == 0x%lx\n",
> +    dev_warn(dev, "%s: format %x not found\n", __func__,
> +        pix->pixelformat);

The `0x%x' versus `%#x' exists in this file too.

Does the `ret' variable and ebusy label give much benefit in
omap1_cam_add_device()?  It seems

> +    if (pcdev->icd) {
> +        ret = -EBUSY;
> +        goto ebusy;
> +    }

could be

    if (pcdev->icd)
        return -EBUSY;

with a plain

    return 0;

at the end, meaning ret and ebusy could be deleted.

Cheers,
Ralph.