[E3-hacking] [PATCH v3 4/5(7)] input: serio: add support for Amstrad Delta serial keyboard port

Dmitry Torokhov dmitry.torokhov at gmail.com
Thu Apr 15 17:14:51 BST 2010


Hi Janusz,

On Thu, Apr 15, 2010 at 04:31:03AM +0200, Janusz Krzysztofik wrote:
> +
> +config SERIO_AMS_DELTA
> +	tristate "Amstrad Delta (E3) mailboard support"
> +	depends on MACH_AMS_DELTA
> +	default y
> +	select AMS_DELTA_FIQ
> +	select KEYBOARD_ATKBD

I'd rather not select atkbd here since it is not required for this
driver to work but simply adjust your defconfig.

> +
> +	if (!(machine_is_ams_delta()))
> +		return -ENODEV;

Extra parens.

Otherwise:

	Acked-by: Dmitry Torokhov <dtor at mail.ru>

I assume it is going to be merged with the rest of your patches through
a tree other than linux-input.

-- 
Dmitry



More information about the e3-hacking mailing list