[E3-hacking] Re: [U-Boot-Users] [PATCH] Add support for Amstrad
wd at denx.de
Sun Oct 8 21:34:39 BST 2006
in message <20060613165927.GE14634 at earth.li> you wrote:
> The attached patch adds support for the Amstrad Delta (E3) Videophone.
> Currently the Amstrad primary bootloader provides the main hardware
> initialisation and then loads u-boot to handle user interaction and
> kernel loading.
> I'd appreciate any comments you may have. Patch is against current git.
I'm afraid I have to reject his patch.
The major reason is that I don't want to see any board specific code
in files like cpu/arm925t/start.S ; maybe you have a good reason for
your modifiations of such a file, but then you must explain it, and
try to implement it in a board-independent way.
Also, there are a few formal resons for the reject: you missed to
include a CHANGELOG entry, and your files violate the Coding Style
requirements (trailing white space, C++ comments, etc.).
Please clean up and resubmit (and while doing this, please also adapt
the makefiles to the new style to allow for building in another
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A star captain's most solemn oath is that he will give his life, even
his entire crew, rather than violate the Prime Directive.
-- Kirk, "The Omega Glory", stardate unknown
More information about the e3-hacking