[cgi-wiki-dev] UseMod formatter, and URL-encoding
Kake L Pugh
cgi-wiki-dev@earth.li
Mon, 24 Jan 2005 19:48:30 +0000
We found a bug in OpenGuides earlier on, caused by this:
This is because the node name parameter is not being properly
URL-encoded before the Location: header is printed to STDOUT. This
bug slipped in because I forgot that CGI::Wiki::Formatter::UseMod's
->node_name_to_node_param method doesn't actually URL-encode, but
expects you to do it yourself after calling the method (this _is_
documented).
I think it perhaps should, since what I expect from that method is
something I can bung into a URL and it will Just Work. However
changing it to do that would break backwards compatibility and could
lead to things being doubly-encoded, which would suck. Thoughts? I
may punt this to cgi-wiki-dev as well.
And here it is. What do people think? Who here is using the UseMod
formatter?
Kake