Nick, You're probably more familiar with Wiki::Toolkit than me at this point.. does this look sane? Dominic. ----- Forwarded message from Earle Martin <earle@downlode.org> ----- X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.3 Date: Sun, 12 Nov 2006 01:39:13 +0000 From: Earle Martin <earle@downlode.org> To: Dominic Hargreaves <dom@earth.li> Subject: Wiki::Toolkit metadata patch Cc: Christopher Schmidt <crschmidt@crschmidt.net> Heya Dom, This is an adaptation for Wiki::Toolkit of the patch Chris posted to the list back in March: http://lists.openguides.org/mail/openguides-dev/2006-April/001252.html The idea is to use it for dropdowns in the edit form of existing categories and locales as in this template: http://boston.openguides.org/templates/edit_form.tt It's untested code, but should work, I think. Cheers, Earle. -- Earle Martin http://downlode.org/ http://purl.org/net/earlemartin/ ----- End forwarded message ----- -- Dominic Hargreaves | http://www.larted.org.uk/~dom/ PGP key 5178E2A5 from the.earth.li (keyserver,web,email)
On Sat, Nov 18, 2006 at 11:22:28AM +0000, Dominic Hargreaves wrote:
Nick,
You're probably more familiar with Wiki::Toolkit than me at this point.. does this look sane?
Oops, here is the patch. -- Dominic Hargreaves | http://www.larted.org.uk/~dom/ PGP key 5178E2A5 from the.earth.li (keyserver,web,email)
On Sat, Nov 18, 2006 at 11:23:22AM +0000, Dominic Hargreaves wrote:
On Sat, Nov 18, 2006 at 11:22:28AM +0000, Dominic Hargreaves wrote:
Nick,
You're probably more familiar with Wiki::Toolkit than me at this point.. does this look sane?
Oops, here is the patch.
I could be wrong, but shouldn't this be abstracted into Wiki::Toolkit::Store::Database or something, so that subclasses which don't use a SQL-backed storage can implement it in a different way? Regards, -- Christopher Schmidt Web Developer
On Sat, 18 Nov 2006, Dominic Hargreaves wrote:
You're probably more familiar with Wiki::Toolkit than me at this point.. does this look sane?
I had to spend 5 minutes checking we didn't already have it under another name, as I was sure we should do! Several snags. As Christopher has already mentioned, we try to avoid having Toolkit.pm do database stuff directly. So, we'll want to split it into a very simple bit in Toolkit.pm, and put the db stuff in Store/Database.pm. Next, it doesn't take account of moderation, or latest versions, so you'll get old categories, categories from spam entries etc. Fixing this will be a little trickier, since we don't want to have to compute the latest moderated version for every metadata row, just once per node. Finally, we'll want a test or two for it I've created a ticket for it, and we can have a bash at this at the hack weekend Nick
participants (3)
-
Christopher Schmidt -
Dominic Hargreaves -
Nick Burch